Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container): add caution #9582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(container): add caution #9582

wants to merge 1 commit into from

Conversation

ematipico
Copy link
Member

Description (required)

More than once users were incorrectly using the containers API, I figured that adding a caution block could help user to understand which API to use, and when.

@ematipico ematipico added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Oct 7, 2024
@ematipico ematipico changed the title fix: add caution fix(container): add caution Oct 7, 2024
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 09506af
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/670404056b9262000838d4da
😎 Deploy Preview https://deploy-preview-9582--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/container-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Comment on lines +73 to +75
:::caution
Outside `vite` or for on-demand usage, you'll have to [load the renderers manually](#adding-a-renderer-manually).
:::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::caution
Outside `vite` or for on-demand usage, you'll have to [load the renderers manually](#adding-a-renderer-manually).
:::
Outside `vite` or for on-demand usage, you'll have to [load the renderers manually](#adding-a-renderer-manually).

Let's try without the big caution first, as this isn't like a security warning or anything, and see if just having it written explicitly here before the example is enough! If you still find people are struggling with this, then we can look at making it more visible!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure. Currently, we already have this phrase in production, and I still get users that use the container API incorrectly. :/

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a great addition @ematipico ! My preference is always to avoid notes etc. for content that is essential, like this is. So I left a suggestion to try without a big flaming caution first, to see whether that's enough.

But the content is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants